Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PropertyListHelper::_get_property returning a valid value even if an index is outside the array valid indices #91760

Merged
merged 1 commit into from
May 10, 2024
Merged

Fix PropertyListHelper::_get_property returning a valid value even if an index is outside the array valid indices #91760

merged 1 commit into from
May 10, 2024
+52 −19

Conversation

groud
Copy link
Member

@groud groud commented May 9, 2024

Closes #91504

@groud groud added this to the 4.3 milestone May 9, 2024
@groud groud requested review from a team as code owners May 9, 2024 12:20
@groud groud mentioned this pull request May 9, 2024
Closed
@KoBeWi
Copy link
Member

KoBeWi commented May 9, 2024

Replaces StringName with MethodBind:

tilebinds.diff.txt

@groud groud force-pushed the fix_PropertyListHelper_not_handling_array_size branch from 5ad4c1d to 602cacc Compare May 9, 2024 16:38
@groud
Copy link
Member Author

groud commented May 9, 2024

Modified with your suggestions. I added you as a co-author.

KoBeWi
KoBeWi reviewed May 9, 2024
View reviewed changes
scene/2d/tile_map.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi reviewed May 9, 2024
View reviewed changes
editor/scene_tree_dock.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga changed the title Fix PropertyListHelper::_get_property returning a valid value even if an index is outside the array valid indices Fix PropertyListHelper::_get_property returning a valid value even if an index is outside the array valid indices May 10, 2024
@groud groud force-pushed the fix_PropertyListHelper_not_handling_array_size branch from 602cacc to 0895cd6 Compare May 10, 2024 08:36
AThousandShips
AThousandShips approved these changes May 10, 2024
View reviewed changes
scene/property_list_helper.h Outdated Show resolved Hide resolved
@groud @KoBeWi
Fix PropertyListHelper::_get_property returning a valid value even if…
7705265 
… an index is outside the array valid indices

Co-authored-by: Tomasz Chabora <[email protected]>
@groud groud force-pushed the fix_PropertyListHelper_not_handling_array_size branch from 0895cd6 to 7705265 Compare May 10, 2024 08:46
@akien-mga akien-mga merged commit 9c388ce into godotengine:master May 10, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

error when changing TileMap to TileMapLayer
4 participants
@groud @KoBeWi @akien-mga @AThousandShips